Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chevron for selects with a non-default size #137

Merged
merged 8 commits into from
May 12, 2023

Conversation

thecrypticace
Copy link
Contributor

Fixes #136

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
tailwindcss-forms ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 1, 2023 at 7:41PM (UTC)

@adamwathan
Copy link
Member

adamwathan commented Feb 25, 2023

Looks like the size attribute can be used to define the width of <input type="password"> and <input type="text"> elements, so we might need to be more careful with the selector here as I think what we have here will add right padding to those elements if a size is defined:

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/size

If we're going to use :where anyways maybe we can qualify the whole thing under select explicitly, like select:where(...)?

They have different specificity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select with size option shows chevron
3 participants