This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
fix: encoded spaces in pathname #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraghazra
commented
Mar 18, 2021
src/lib/setupContext.js
Outdated
| @@ -183,8 +182,7 @@ function trackModified(files) { | |||
| let changed = false | |||
|
|
|||
| for (let file of files) { | |||
| let pathname = url.parse(file).pathname | |||
| let newModified = fs.statSync(pathname).mtimeMs | |||
| let newModified = fs.statSync(file).mtimeMs | |||
There was a problem hiding this comment.
Another way we can fix this is by decoding the URI component.
let pathname = url.parse(file).pathname
let newModified = fs.statSync(decodeURIComponent(pathname)).mtimeMsbut I think just that file variable will also work, I'm not sure about why url.parse is used here. as mentioned in #22 (comment)
There was a problem hiding this comment.
Hey! The reason we parse it is because in Vite, the path will often have query params like:
/Users/adam/code/my-project/src/App.vue?style=blah
...and trying to do a statSync call on that will file if we don't just grab the real file path. So I think the decodeURIComponent solution is probably the right move 👍 Thanks so much for this PR!
There was a problem hiding this comment.
Cool! Okay i will then change it to use decodeURIComponent
z-x
approved these changes
Mar 18, 2021
|
Merged, will tag this in a little bit, thank you! 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22