This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
feat: allow custom extractors #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kombucha
force-pushed
the
allow-custom-extractors
branch
from
f2677f0
to
e82bb0f
Compare
kombucha
force-pushed
the
allow-custom-extractors
branch
3 times, most recently
from
1dea69d
to
092e067
Compare
kombucha
force-pushed
the
allow-custom-extractors
branch
from
092e067
to
88e7bd0
Compare
kombucha
commented
Mar 20, 2021
Comment on lines
+6
to
+7
| jest.resetModules() | ||
| const tailwind = require('../src/index.js') |
There was a problem hiding this comment.
I've noticed that the second test in that file would pass even when it shouldn't, as long as the first one passed. I think it's due to this module sharedState which survives across multiple call in the same process.
That's why I'm calling resetModules, which resets require's cache and gives me a fresh new instance on each run.
|
This is great thanks so much! Going to play with it a bit and hopefully get it out in a release today for people to play with 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a ui library using Tailwind which relies heavily on a custom purge extractor, which means I wouldn't be able to leverage
tailwindcss-jit😿 .This PR aims to support custom extractors as defined in the purge config options if any, falling back to the default one from
tailwindcss-jit.I tried to make as few modifications as I could to the code
I'm hoping you're on board with the general idea 🙏