Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordered list style type s modifier position #137

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

neupauer
Copy link
Contributor

@neupauer neupauer commented Feb 8, 2021

Case-sensitive modifier s should be outside the attribute value. This PR fix that. Eg. ol[type="A s"] -> ol[type="A" s]

Visual preview of the result:
list-style-demo

Currently only Firefox displays all types correctly until the Chrome (Edge, Opera) bug is resolved.
See MDN - Browser compatibility

Signed-off-by: Peter Neupauer <peter@neupauer.sk>
@RobinMalfait RobinMalfait merged commit 95bb9eb into tailwindlabs:master Feb 12, 2021
@RobinMalfait
Copy link
Member

Hey! Thank you for your PR!
Much appreciated! 🙏

Good catch, I thought that it had to be "inside" but clearly missed that, nice catch!

Copy link

@brennanangel brennanangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastienbarre
Copy link

sebastienbarre commented Jun 26, 2021

Hi. I believe this is triggering some weird and very sizable warnings at build time now in some configs.

See

I'm experiencing it as well, and was able to address the issue by switching by to 0.4.0 for now.

@sebastienbarre
Copy link

Update. After discussing this in #4722 · tailwindlabs/tailwindcss, @adamwathan opened Warns incorrectly on CSS attribute selector case sensitivity flag · Issue #1397 · evanw/esbuild, which was promptly fixed today, so it's likely to land in esbuild v0.12.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants