Refactor

tailwindlabs · Mar 29, 2023 · 87aef2f · 87aef2f
1 parent 75d0f22
commit 87aef2f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/lib/expandApplyAtRules.js b/src/lib/expandApplyAtRules.js
@@ -567,7 +567,7 @@ function processApply(root, context, localCache) {
             // Move pseudo elements to the end of the selector (if necessary)
             let selector = parser().astSync(rule.selector)
             selector.each((sel) => {
-              let [pseudoElements] = collectPseudoElements(sel, true, [':is', ':has'])
+              let [pseudoElements] = collectPseudoElements(sel)
               if (pseudoElements.length > 0) {
                 sel.nodes.push(...pseudoElements.sort(sortSelector))
               }

diff --git a/src/util/formatVariantSelector.js b/src/util/formatVariantSelector.js
@@ -248,7 +248,7 @@ export function finalizeSelector(current, formats, { context, candidate, base })
   selector.each((sel) => {
     let [pseudoElements] = collectPseudoElements(sel)
     if (pseudoElements.length > 0) {
-      sel.nodes.push(pseudoElements.sort(sortSelector))
+      sel.nodes.push(...pseudoElements.sort(sortSelector))
     }
   })
 
@@ -365,15 +365,11 @@ export function containsNode(selector, values) {
  * @param {boolean} force
  * @param {string[]|null} safelist
  **/
-export function collectPseudoElements(selector, force = false, safelist = null) {
+export function collectPseudoElements(selector, force = false) {
   /** @type {Node[]} */
   let nodes = []
   let seenPseudoElement = null
 
-  if (safelist !== null && !containsNode(selector, safelist)) {
-    return [[], seenPseudoElement]
-  }
-
   for (let node of [...selector.nodes]) {
     if (isPseudoElement(node, force)) {
       nodes.push(node)
@@ -389,7 +385,14 @@ export function collectPseudoElements(selector, force = false, safelist = null)
     }
 
     if (node?.nodes) {
-      let [collected, seenPseudoElementInSelector] = collectPseudoElements(node, force)
+      let hasPseudoElementRestrictions =
+        node.type === 'pseudo' && (node.value === ':is' || node.value === ':has')
+
+      let [collected, seenPseudoElementInSelector] = collectPseudoElements(
+        node,
+        force || hasPseudoElementRestrictions
+      )
+
       if (seenPseudoElementInSelector) {
         seenPseudoElement = seenPseudoElementInSelector
       }