-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't add spaces to gradients and grid track names when followed by calc()
#12704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2024
thecrypticace
added a commit
that referenced
this pull request
Jan 3, 2024
…calc()` (#12704) * Don’t break gradient functions when following `calc()` * Don’t break CSS grid track names * Update changelog
This was referenced May 19, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do spacing normalization around operators so you can write things like
w-[calc(100%-2px)]
and not have to worry about inserting spaces. We use a combination of regex and a mini lexer for this but the regexes are prone to over matching.This PR adds a targeted fix that prevents us from inserting spaces for the following CSS functions:
radial-gradient
linear-gradient
conic-gradient
repeating-radial-gradient
repeating-linear-gradient
repeating-conic-gradient
Additionally, I've added a fix that prevents the addition of spaces around
-
when inside a CSS grid track name that's encased in square brackets.Before:
After:
An even better solution would be to eventually introduce a lexer that's more top-level and understands CSS function syntax but that will have to happen another day.
Fixes #12654
Fixes #12665