Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use length data type for background-size instead of background-position #13771

Merged
merged 5 commits into from
May 31, 2024
Merged

Use length data type for background-size instead of background-position #13771

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dff8fa7
move `length` data type from `background-position` to `background-size`
RobinMalfait May 31, 2024
855d9dd
sort data types
RobinMalfait May 31, 2024
c820f95
update changelog
RobinMalfait May 31, 2024
ce0dd72
make sure `length` is inferred later
RobinMalfait May 31, 2024
bdb7d07
add explicit test cases for `length` and `size` data types
RobinMalfait May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Nothing yet!
### Fixed

- Use `length` data type for `background-size` instead of `background-position` ([#13771](https://github.com/tailwindlabs/tailwindcss/pull/13771))

## [4.0.0-alpha.15] - 2024-05-08

Expand Down
6 changes: 3 additions & 3 deletions packages/tailwindcss/src/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,13 +2510,13 @@ export function createUtilities(theme: Theme) {
])

switch (type) {
case 'length':
case 'percentage':
case 'position': {
return [decl('background-position', value)]
}
case 'size':
case 'bg-size': {
case 'bg-size':
case 'length':
case 'size': {
return [decl('background-size', value)]
}
case 'image':
Expand Down
Loading