-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rtl/ltr to work with dir=auto #14306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
reviewed
Sep 2, 2024
shedokan
force-pushed
the
fix-dir-auto
branch
from
September 4, 2024 11:57
ab13ef2
to
5250b3d
Compare
@adamwathan Thanks for the suggestion, fixed and merged. |
adamwathan
force-pushed
the
fix-dir-auto
branch
from
September 18, 2024 13:34
03ef39d
to
380e294
Compare
adamwathan
approved these changes
Sep 18, 2024
adamwathan
force-pushed
the
fix-dir-auto
branch
from
September 23, 2024 13:07
edaf514
to
0887724
Compare
philipp-spiess
force-pushed
the
fix-dir-auto
branch
from
September 23, 2024 15:08
0887724
to
22d5ff5
Compare
Thanks for tackling this one! This will be available in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issue #14305 by using
:dir()