Skip candidates with invalid theme()
calls
#14437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when we encounter a candidates with invalid
theme()
calls we throw an error which stops the build entirely. This is not ideal because, especially in the case ofnode_modules
, if one file in one package has an error it will stop the build for an entire project and tracking this down can be quite difficult.Now, after this PR, any candidates that use
theme(…)
with non-existent theme keys (e.g.rounded-[theme(--radius-does-not-exist)]
) will be skipped instead of breaking the build.Before:
After: