Migrate legacy classes to the v4 alternative #14643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing through the extension, but weren't using it.
RobinMalfait
force-pushed
the
feat/migrate-legacy-classes
branch
from
1a958f4 to
8a09726
Compare
RobinMalfait
changed the title
with the `in`, we go up the prototype chain. Which means that this
happens:
```js
let utility = 'constructor'
utility in LEGACY_CLASS_MAP // true
LEGACY_CLASS_MAP[utility].toString() // function Object() { [native code] }
```
We will register empty utilities for the old legacy classes, this way we can rely on the design system and the real parser to get an Candidate AST out of the rawCandidate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mapping from legacy classes to new classes. For example, the
flex-shrink-0is still used in our projects, but is deprecated in v3.The migration does a tiny bit of parsing because we can't rely on
designSystem.parseCandidate(…)because this requires the utility to be defined which is not the case for legacy classes.This migration runs after the migration where we handle prefixes, so we don't have to worry about that. We do have to worry about the
!location, because theimportantmigration also relies on thedesignSystem.overflow-cliptext-clipoverflow-ellipsistext-ellipsisflex-grow-0grow-0flex-shrink-0shrink-0decoration-clonebox-decoration-clonedecoration-slicebox-decoration-slice