Migrate arbitrary values to bare values #14669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
requested review from
philipp-spiess,
thecrypticace and
adamwathan
and removed request for
philipp-spiess and
thecrypticace
Comment on lines
25
to
32
| let percentage = parseFloat(clone.value.value) | ||
| if (percentage >= 50 && percentage <= 200) { | ||
| changed = true | ||
| clone.value = { | ||
| kind: 'named', | ||
| value: clone.value.value, | ||
| fraction: null, | ||
| } |
There was a problem hiding this comment.
I think only whole numbers are valid for bare values but this might also convert e.g. font-stretch-[50.5%] now
There was a problem hiding this comment.
font-stretch-50.5% does work, but don't know if that should though.... wrote something on Discord about it because it feels a bit inconsistent compared to let's say opacity-50% (doesn't do anything), but opacity-50 does 😅
There was a problem hiding this comment.
Alright, let's clean that up. Created a separate PR to solve the actual issue in the utility: #14670
RobinMalfait
force-pushed
the
feat/bare-value-codemods
branch
from
d9ee84f to
b436ef9
Compare
RobinMalfait
force-pushed
the
feat/bare-value-codemods
branch
from
b436ef9 to
0d31180
Compare
philipp-spiess
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a codemod that can convert arbitrary values to the cleaner bare values if we can.
For example, some classes use arbitrary values such as
col-start-[16], but in v4 we have bare values for some plugins that don't really need to adhere to your design system.In this case, we can convert
col-start-[16]to justcol-start-16.Another use case is for utilities that use fractions. For example the
aspect-*plugin.A custom aspect ratio such as
aspect-[16/9]can be converted toaspect-16/9.There are some rules attached to this migration: