-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve theme keys when migrating JS config to CSS #14675
Conversation
d12009e
to
bd66cec
Compare
34847f3
to
3456edd
Compare
56e01bd
to
6c482c7
Compare
6c482c7
to
cb93881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the test failures (color palette related). Fix those up and should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but some small changes
@config '../tailwind.config.ts'; | ||
|
||
@theme { | ||
--color-gray-50: oklch(0.985 0 none); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR didn't introduce it, but I wonder if the "legacy" colors (v3) should still use the v3 values (hex) instead of oklch(…)
🤔
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
With the changes in #14672, it now becomes trivial to actually resolve the config (while still retaining the reset behavior). This means that we can now convert JS configs that use functions, e.g.:
This becomes: