-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Migrate static plugins with options to CSS #14700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate static plugins with options to CSS #14700
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @philipp-spiess and the rest of your teammates on |
c0e6536 to
20d0c57
Compare
f13c00d to
9a66a68
Compare
20d0c57 to
438c487
Compare
9a66a68 to
f54c6bf
Compare
f54c6bf to
a0d1616
Compare
438c487 to
aab02ca
Compare
3ca31c4 to
10abcec
Compare
| await format(node.toString(), { | ||
| parser: 'css', | ||
| semi: true, | ||
| singleQuote: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we inconsistently used single quotes for the @plugin and @config directives but double-quotes for CSS values so this is just a consistency change.
aab02ca to
09c0aab
Compare
10abcec to
ea4e2bd
Compare
09c0aab to
3c0528a
Compare
ea4e2bd to
ab2514d
Compare
d775256 to
34fc9b0
Compare
a45db82 to
9f6e422
Compare
9f6e422 to
d45b2ec
Compare

This PR extends our JS configuration to CSS migration by also allowing
pluginswith options.An example of such config would be:
If the option object contains only values allowed in our CSS API, we can convert this to CSS entirely: