Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always emit keyframes registered in addUtilities #14747

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

thecrypticace
Copy link
Contributor

Fixes #14732

cc @philipp-spiess this look like an okay fix?

@thecrypticace thecrypticace requested a review from a team as a code owner October 21, 2024 22:17
@adamwathan
Copy link
Member

Wonder if all we actually need to do is revert this one line change?

https://github.com/tailwindlabs/tailwindcss/pull/14672/files#diff-5558c180ba5a080e430ff267430cee62a03a9deedf65a6e8fb5d7c685813c88f

Do @keyframes added this way even need to be registered with the theme at all or should we just add them as static CSS rules? The latter sounds more right to me without getting too deep into it.

@philipp-spiess
Copy link
Member

Ahhh... of course. 🤕 We should probably add a test in the plugin-api spec for this that only uses addBase in a plugin and ensures the keyframe is emitted?

I’m with @adamwathan here in that this feels like it should go directly in the CSS. This way we can also keep the core layer pristine.

@thecrypticace
Copy link
Contributor Author

Ah yeah directly inserting into the AST seems more reasonable. I'll make that change. Ditto w/ addBase + tests

@thecrypticace thecrypticace force-pushed the fix/v4-always-emit-add-utilities-keyframes branch 2 times, most recently from 4d8841b to bb1a981 Compare October 22, 2024 13:33
Copy link
Member

philipp-spiess commented Oct 22, 2024

Merge activity

  • Oct 22, 12:07 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 22, 12:08 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 22, 12:09 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Oct 22, 12:28 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 22, 12:33 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 22, 12:39 PM EDT: A user merged this pull request with the Graphite merge queue.

@thecrypticace thecrypticace force-pushed the fix/v4-always-emit-add-utilities-keyframes branch from 35d2bb2 to c0f2922 Compare October 22, 2024 16:34
@graphite-app graphite-app bot merged commit c0f2922 into next Oct 22, 2024
2 checks passed
@graphite-app graphite-app bot deleted the fix/v4-always-emit-add-utilities-keyframes branch October 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 alpha 0.28 breaks plugin (tailwindcss-animate) & weird behavior with new p3 color opacity
3 participants