Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postcss as a dependency of @tailwindcss/postcss #14750

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Oct 22, 2024

This PR adds postcss as a dependency of @tailwindcss/postcss.

If you are in an environment with Next.js where you can use the @tailwindcss/postcss package, then postcss is required.

If you have postcss in your package.json, then everything is fine, however if you don't then you will get an error that postcss cannot be found.

Note: this only happens when you are using npm, if you are using pnpm, then the postcss package can be resolved correctly and you won't run into issues. This is also why the integration tests just worked (because we use pnpm).

To make sure that this package works for most people in most environments, we explicitly add postcss as a dependency of @tailwindcss/postcss.


I wanted to create an integration test for this to make sure this works, but we are currently using pnpm with some of pnpm's features to make sure that we can override dependencies that point to .tgz files.

@RobinMalfait RobinMalfait requested a review from a team as a code owner October 22, 2024 11:14
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RobinMalfait and the rest of your teammates on Graphite Graphite

@RobinMalfait RobinMalfait enabled auto-merge (squash) October 22, 2024 11:17
@RobinMalfait RobinMalfait merged commit 557ed8c into next Oct 22, 2024
2 checks passed
@RobinMalfait RobinMalfait deleted the robin/fix/add-postcss-dependency branch October 22, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants