Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Migrate max-w-screen-* candidates #14754

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Oct 22, 2024

This PR migrates max-w-screen-* candidates to the v4 equivalent relying on the breakpoint var: max-w-[var(--breakpoint-*)]

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @philipp-spiess and the rest of your teammates on Graphite Graphite

@philipp-spiess philipp-spiess force-pushed the 10-22-upgrade_migrate_max-w-screen-_candidates branch 2 times, most recently from 082b42d to 48dad29 Compare October 22, 2024 13:36
@philipp-spiess philipp-spiess marked this pull request as ready for review October 22, 2024 13:36
@philipp-spiess philipp-spiess requested a review from a team as a code owner October 22, 2024 13:36
@@ -7,6 +7,7 @@ import { arbitraryValueToBareValue } from './codemods/arbitrary-value-to-bare-va
import { automaticVarInjection } from './codemods/automatic-var-injection'
import { bgGradient } from './codemods/bg-gradient'
import { important } from './codemods/important'
import { maxWScreen } from './codemods/max-w-screen'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this maxWidthScreen instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we should

@philipp-spiess philipp-spiess force-pushed the 10-22-upgrade_migrate_max-w-screen-_candidates branch from 48dad29 to b63f791 Compare October 22, 2024 15:01
Copy link
Member Author

philipp-spiess commented Oct 22, 2024

Merge activity

  • Oct 22, 12:07 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 22, 12:09 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 22, 12:31 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Oct 22, 12:33 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 22, 12:37 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 22, 12:46 PM EDT: A user merged this pull request with the Graphite merge queue.

This PR migrates `max-w-screen-*` candidates to the v4 equivalent relying on the breakpoint var: `max-w-[var(--breakpoint-*)]`
@RobinMalfait RobinMalfait force-pushed the 10-22-upgrade_migrate_max-w-screen-_candidates branch from 0d9b6d0 to fc261bd Compare October 22, 2024 16:40
@graphite-app graphite-app bot merged commit fc261bd into next Oct 22, 2024
2 checks passed
@graphite-app graphite-app bot deleted the 10-22-upgrade_migrate_max-w-screen-_candidates branch October 22, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants