Resolve third-party plugins with exports in their package.json
#14775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @philipp-spiess and the rest of your teammates on |
philipp-spiess
force-pushed
the
10-24-resolve_third-party_plugins_with_exports_in_their_package.json_
branch
from
261a308 to
0c8bebd
Compare
…ts_in_their_package.json_
adamwathan
approved these changes
Oct 24, 2024
adamwathan
deleted the
10-24-resolve_third-party_plugins_with_exports_in_their_package.json_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when trying to resolve plugins with
exportsin theirpackage.json, like@headlessui/tailwindcss. The missingconditionNamesin the enhanced resolver config would cause it to not properly look up the name.Test Plan
I added a test using the
postcsssetup (the existing plugin tests are inside the CLI setup but the CLI can only ever run in Module JS mode).To ensure the tests are resolving to the right environment (CJS vs MJS), I added logging of the
import.meta.urlvalue to the resolver code. When run, this was the output: