Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure underscore in theme() are also preserved #14781

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Ensure underscore in theme() are also preserved #14781

merged 1 commit into from
Oct 24, 2024

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Oct 24, 2024 •
edited
Loading

Quick follow-up to #14776 to treat the theme() function the same way.

@philipp-spiess Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @philipp-spiess and the rest of your teammates on Graphite Graphite

@philipp-spiess philipp-spiess marked this pull request as ready for review October 24, 2024 15:49
@philipp-spiess philipp-spiess requested a review from a team as a code owner October 24, 2024 15:49
@philipp-spiess philipp-spiess force-pushed the 10-24-ensure_underscore_in_theme_are_also_preserved branch 2 times, most recently from 20dfaef to e44faf2 Compare October 24, 2024 15:51
adamwathan
adamwathan reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@adamwathan adamwathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we think of any situation where it's important to handle theme(--spacing-1) and theme(spacing.1) differently here with regards to the underscore escape stuff?

@philipp-spiess philipp-spiess force-pushed the 10-24-ensure_underscore_in_theme_are_also_preserved branch from e44faf2 to a95eea9 Compare October 24, 2024 15:58
@philipp-spiess
Copy link
Member Author

@adamwathan It's a breaking change from v3 for sure but so is the var(...) stuff. Let me add an integration test with a space in the color namespace or so and see what happens 😬

I fear that the codemod should handle this or so and just replace it to _ maybe lol

@adamwathan adamwathan merged commit dc9e034 into next Oct 24, 2024
2 checks passed
@adamwathan adamwathan deleted the 10-24-ensure_underscore_in_theme_are_also_preserved branch October 24, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwathan adamwathan adamwathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipp-spiess @adamwathan