Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier-plugin-tailwindcss to latest version during upgrade #14808

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

RobinMalfait
Copy link
Member

This PR adds a migration to bump the prettier-plugin-tailwindcss version to the latest version when upgrading your project. This is to ensure that the plugin is compatible with the latest version of Tailwind CSS.

Note: we will only do this if you already used the prettier-plugin-tailwindcss plugin in your project.

@RobinMalfait RobinMalfait requested a review from a team as a code owner October 28, 2024 13:44
expect(pkg.devDependencies).toMatchObject({
'prettier-plugin-tailwindcss': expect.any(String),
})
expect(pkg.devDependencies['prettier-plugin-tailwindcss']).not.toEqual('0.5.0')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was using a snapshot before, but that would break every time we bump the version. Alternatively we could parse the version and ensure it's higher compared to what it is in this test.

@RobinMalfait RobinMalfait force-pushed the feat/migrate-bump-prettier-plugin-tailwindcss branch from 2d097e1 to 203704d Compare October 28, 2024 23:41
@RobinMalfait RobinMalfait enabled auto-merge (squash) October 28, 2024 23:41
@RobinMalfait RobinMalfait merged commit 4e5e0a3 into next Oct 28, 2024
1 check passed
@RobinMalfait RobinMalfait deleted the feat/migrate-bump-prettier-plugin-tailwindcss branch October 28, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants