Fix crash when using @source containing ..
#14831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/crash-when-using-source
branch
from
5c44bc7 to
f229783
Compare
RobinMalfait
force-pushed
the
fix/crash-when-using-source
branch
from
f229783 to
3953681
Compare
RobinMalfait
changed the title
@source with path that ends in ..@source containing ..
RobinMalfait
changed the title
@source containing ..@source containing ..
thecrypticace
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a
@sourcecrashes when the path eventually resolves to a path ending in...We have to make sure that we canonicalize the path to make sure that we are working with the real directory.