Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whitespace around , separator #14838

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Remove whitespace around , separator #14838

merged 4 commits into from
Oct 31, 2024

Conversation

RobinMalfait
Copy link
Member

This PR is an improvement/fix by making sure that whitespace around the , separator is removed when printing arbitrary values.

Before:

- <div class="grid-cols-[min(50%,theme(spacing.80))_auto]"></div>
+ <div class="grid-cols-[min(50%,_var(--spacing-80))_auto]"></div>

After:

- <div class="grid-cols-[min(50%,theme(spacing.80))_auto]"></div>
+ <div class="grid-cols-[min(50%,var(--spacing-80))_auto]"></div>

@RobinMalfait
update tests
428c1f0
@RobinMalfait
print , as , in arbitrary variants
77ac17e 
E.g.: `m-[min(1px,_2px)]` -> `m-[min(1px,2px)]`
@RobinMalfait RobinMalfait requested a review from a team as a code owner October 30, 2024 21:26
@RobinMalfait @thecrypticace
Update packages/@tailwindcss-upgrade/src/template/codemods/theme-to-v…
469c2c0 
…ar.test.ts

Co-authored-by: Jordan Pittman <jordan@cryptica.me>
@RobinMalfait RobinMalfait merged commit 0b5736f into next Oct 31, 2024
1 check passed
@RobinMalfait RobinMalfait deleted the fix/improve-arbitrary-value-minifier branch October 31, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecrypticace thecrypticace thecrypticace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinMalfait @thecrypticace