Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config types for boxShadow #14856

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

tremby
Copy link

@tremby tremby commented Nov 1, 2024

boxShadow accepts multiple shadows just like dropShadow does. This patch fixes the TS typings to reflect that.

See demo showing that multiple shadows are supported (complete with it incorrectly complaining that the config is bad) here: https://play.tailwindcss.com/VHqWbbEIrz?file=config

@tremby tremby requested a review from a team as a code owner November 1, 2024 22:27
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me, it's consistent to what we already do with dropShadow now 👍 Do you mind adding a changlog entry? :)

`boxShadow` accepts multiple shadows just like `dropShadow` does.
@tremby
Copy link
Author

tremby commented Nov 4, 2024

Sure; added.

@tremby tremby requested a review from philipp-spiess November 4, 2024 21:02
CHANGELOG.md Outdated Show resolved Hide resolved
@philipp-spiess philipp-spiess merged commit 4de0769 into tailwindlabs:main Nov 7, 2024
@philipp-spiess
Copy link
Member

Thanks @tremby! Highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants