Fix config types for boxShadow #14856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me, it's consistent to what we already do with dropShadow now 👍 Do you mind adding a changlog entry? :)
`boxShadow` accepts multiple shadows just like `dropShadow` does.
Author
|
Sure; added. |
philipp-spiess
approved these changes
Nov 7, 2024
Member
|
Thanks @tremby! Highly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boxShadowaccepts multiple shadows just likedropShadowdoes. This patch fixes the TS typings to reflect that.See demo showing that multiple shadows are supported (complete with it incorrectly complaining that the config is bad) here: https://play.tailwindcss.com/VHqWbbEIrz?file=config