Rename --letter-spacing-* variables to --tracking-*
#14921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
change/rename-letter-spacing-var-to-tracking
branch
from
1872e36 to
8491b73
Compare
philipp-spiess
force-pushed
the
change/rename-letter-spacing-var-to-tracking
branch
from
8491b73 to
a509dd6
Compare
adamwathan
approved these changes
Nov 8, 2024
philipp-spiess
deleted the
change/rename-letter-spacing-var-to-tracking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the current changes, we also want to make the
--letter-spacing-*namespace closer to the utility name so we're renaming it to--tracking-*:@theme { - --letter-spacing-tighter: -0.05em; - --letter-spacing-tight: -0.025em; - --letter-spacing-normal: 0em; - --letter-spacing-wide: 0.025em; - --letter-spacing-wider: 0.05em; - --letter-spacing-widest: 0.1em; /* ... */ + --tracking-tighter: -0.05em; + --tracking-tight: -0.025em; + --tracking-normal: 0em; + --tracking-wide: 0.025em; + --tracking-wider: 0.05em; + --tracking-widest: 0.1em; /* ... */ }Test Plan
Added cases to the CSS
theme()variable/JS plugin tests (interop layer) and the integration tests (codemod layer).