Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Migrate ring to ring-3 #15063

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Nov 21, 2024

This PR adds a codemod for migrating ring to ring-3 if it is safe to do so.

Test plan

Added a ring to the Catalyst project and then migrated it:
image

@RobinMalfait RobinMalfait requested a review from a team as a code owner November 21, 2024 13:14
@RobinMalfait RobinMalfait force-pushed the feat/migrate-ring-utilities branch from 9da859c to c9a166b Compare November 21, 2024 13:16
@philipp-spiess philipp-spiess changed the title Migrate ring to ring-3 Upgrade: Migrate ring to ring-3 Nov 21, 2024
@RobinMalfait RobinMalfait enabled auto-merge (squash) November 21, 2024 13:19
@RobinMalfait RobinMalfait merged commit c4feedb into next Nov 21, 2024
1 check passed
@RobinMalfait RobinMalfait deleted the feat/migrate-ring-utilities branch November 21, 2024 13:20
RobinMalfait added a commit that referenced this pull request Nov 21, 2024
This PR adds a codemod for migrating `ring` to `ring-3` if it is safe to
do so.


# Test plan

Added a `ring` to the Catalyst project and then migrated it:
<img width="864" alt="image"
src="https://github.com/user-attachments/assets/163d9faa-c712-494e-b9d7-106508157915">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants