Throw when layer(…) in @import is in the incorrect spot
#15109
+84
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
reviewed
Nov 22, 2024
RobinMalfait
force-pushed
the
feat/warn-when-invalid-layer-is-found
branch
from
54a8d3f
to
7456de2
Compare
RobinMalfait
force-pushed
the
feat/warn-when-invalid-layer-is-found
branch
from
c6e0940
to
9855d12
Compare
Co-authored-by: Adam Wathan <adam.wathan@gmail.com>
If any of the errors occur, we can bail and keep the `@import` in the final CSS. If something went wrong, the browser will let you know that something is missing.
RobinMalfait
force-pushed
the
feat/warn-when-invalid-layer-is-found
branch
from
9855d12
to
9b2e98f
Compare
thecrypticace
approved these changes
Nov 22, 2024
philipp-spiess
approved these changes
Nov 22, 2024
Co-authored-by: Philipp Spiess <hello@philippspiess.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR throws an error when we notice that an
layer(…)in an@importor@mediais incorrect.This hints the user to ensure that
layer(…)in an@importshould be the first condition. In case of an@media, it should be an@layer …instead.