Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare transform properties with "*" syntax instead of "<transform-function>" #15179

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

adamwathan
Copy link
Member

Fixes #15144.

Weird bug in Safari that breaks 3D transforms when using registered custom properties registered with the "" type:

https://bugs.webkit.org/show_bug.cgi?id=283487

Declaring them as just "*" fixes it with no apparent downside since transitioning these 3D transforms still works, and usually transitions/animations are the reason you'd type these properties.

Evidence of rotations looking the same in all browsers here:

image

@adamwathan adamwathan requested a review from a team as a code owner November 25, 2024 21:12
@adamwathan adamwathan merged commit 8217b5c into next Nov 26, 2024
1 check passed
@adamwathan adamwathan deleted the fix/safari-3d-transform-bug branch November 26, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4]: rotate-y-* utilities rotate in the x dimension in Safari
2 participants