Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference imports should not generate utilities #15307

Merged

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Dec 5, 2024

We noticed an issue where the new @import "…" reference syntax was not throwing away @tailwind declarations, effectively causing you to create utility classes whenever you used this feature.

This is especially noticed in setups with very strict compilers like Svelte.

Test Plan

Before

Screenshot 2024-12-05 at 11 56 00

After

Screenshot 2024-12-05 at 12 27 30

@philipp-spiess philipp-spiess force-pushed the fix/reference-import-should-not-create-utilities branch 2 times, most recently from 051fdba to 204b444 Compare December 5, 2024 11:41
@philipp-spiess philipp-spiess marked this pull request as ready for review December 5, 2024 11:46
@philipp-spiess philipp-spiess requested a review from a team as a code owner December 5, 2024 11:46
@philipp-spiess philipp-spiess force-pushed the fix/reference-import-should-not-create-utilities branch from 204b444 to 22aeddf Compare December 5, 2024 12:05
@philipp-spiess philipp-spiess merged commit 1238d07 into next Dec 5, 2024
1 check passed
@philipp-spiess philipp-spiess deleted the fix/reference-import-should-not-create-utilities branch December 5, 2024 15:18
@madmoizo
Copy link

madmoizo commented Dec 6, 2024

It happens even if you do not use reference keyword.
For reference:
Repo of a base sveltekit + tailwind app
Discord report
css output

@philipp-spiess
Copy link
Member Author

@madmoizo Hey! your issue seems unrelated to the reference import. I responded to the discord thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants