Fix PostCSS watcher warnings on Windows #15321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
approved these changes
Dec 6, 2024
This comment was marked as spam.
This comment was marked as spam.
|
This probably also fixes my issue here #15175 |
|
@aymanoid Oh yep that seems like the same issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15320
Resolves #15175
Turns out that the postcss file watcher does not like our Unix based paths and will print a warning about them. This fixes the issue by calling
path.resolve()to convert it back to a Windows-style absolute path if necessary.Test Plan
Tested on Windows with a new Next.js 14 project. Ensured that file reloads also still work (changes to the
tsxfile are picked up correctly). Also ensure that the CI runs on Windows.Before
After