Ensure Symbol.dispose and Symbol.asyncDispose are available
#15404
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`process.stdout.write` returns a boolean by default, but for the type of the flush method we don't care about the return type.
RobinMalfait
force-pushed
the
fix/issue-15399
branch
4 times, most recently
from
bcb8aca to
b382399
Compare
RobinMalfait
force-pushed
the
fix/issue-15399
branch
from
b382399 to
6a2e05e
Compare
This should bring us past the `Object not disposable` error due to the `Symbol.dispose` and `Symbol.asyncDispose` not being available.
This reverts commit 6a2e05e.
RobinMalfait
changed the title
Symbol.dipose and Symbol.asyncDispose are availableSymbol.dispose and Symbol.asyncDispose are available
RobinMalfait
force-pushed
the
fix/issue-15399
branch
from
2a8bcfc to
fa868a6
Compare
| @@ -763,3 +765,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Move the CLI into a separate `@tailwindcss/cli` package ([#13095](https://github.com/tailwindlabs/tailwindcss/pull/13095)) | |||
|
|
|||
| ## [4.0.0-alpha.1] - 2024-03-06 | |||
|
|
|||
There was a problem hiding this comment.
Yep, was removed in some previous PR for some reason.
I think we should actually just add an empty placeholder or remove this empty header 😅
thecrypticace
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently introduced some better instrumentation (#15303) which uses the new
usingkeyword. I made sure that this was compiled correctly for environments whereusingis not available yet.The issue is that this also relies on
Symbol.disposebeing available. In my testing on our minimal required Node.js version (18) it did work fine. However, turns out that I was using18.20.xlocally whereSymbol.disposeis available, but on older version of Node.js 18 (e.g.:18.17.x) it is not available. This now results in some completely broken builds, e.g.: when running on Cloudflare Pages. See: #15399I could reproduce this error in CI, by temporarily downgrading the used Node.js version to
18.17.0. See:Implementing the proper polyfill, as recommended by the TypeScript docs ( see: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html#:~:text=Symbol.dispose,-??=%20Symbol(%22Symbol.dispose ), the error goes away. (If you look at CI after the polyfill, it still fails but for different reasons unrelated to this change)
Fixes: #15399
Test plan
Object not disposable.Before
It works on Node.js v18.20.x, but switching to Node.js v18.17.x you can see it fail:
After
Using pnpm's overrides, we can apply the fix from this PR and test it in the reproduction. You'll notice that it now works in both Node.js v18.20.x and v18.17.x