Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double translate-z-px values #16718

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Remove double translate-z-px values #16718

merged 3 commits into from
Feb 21, 2025
+9 −12

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where if you used translate-z-px or -translate-z-px that the utility was generated twice:

.translate-z-px {
  --tw-translate-z: 1px;
  translate: var(--tw-translate-x) var(--tw-translate-y) var(--tw-translate-z);
}
.translate-z-px {
  --tw-translate-z: 1px;
  translate: var(--tw-translate-x) var(--tw-translate-y) var(--tw-translate-z);
}
@property --tw-translate-x {
  syntax: "*";
  inherits: false;
  initial-value: 0;
}
@property --tw-translate-y {
  syntax: "*";
  inherits: false;
  initial-value: 0;
}
@property --tw-translate-z {
  syntax: "*";
  inherits: false;
  initial-value: 0;
}

With this PR, it will only generate once:

.translate-z-px {
  --tw-translate-z: 1px;
  translate: var(--tw-translate-x) var(--tw-translate-y) var(--tw-translate-z);
}
@property --tw-translate-x {
  syntax: "*";
  inherits: false;
  initial-value: 0;
}
@property --tw-translate-y {
  syntax: "*";
  inherits: false;
  initial-value: 0;
}
@property --tw-translate-z {
  syntax: "*";
  inherits: false;
  initial-value: 0;
}

@RobinMalfait RobinMalfait requested a review from a team as a code owner February 21, 2025 13:54
@RobinMalfait RobinMalfait mentioned this pull request Feb 21, 2025
Merged
@RobinMalfait
add failing test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7465d26 
- update test to include `translate-z-px` and `-translate-z-px`
- remove the additional `translate: …` properties

These should be fixed by the next commit
@RobinMalfait
remove hardcoded -translate-z-px and translate-z-px
66a1583 
These are already covered by the `translate` functional utility.
@RobinMalfait
update changelog
Loading
Loading status checks…
1bdf94a
@RobinMalfait RobinMalfait force-pushed the fix/double-translate-z-px branch from ffbcd26 to 1bdf94a Compare February 21, 2025 14:05
@RobinMalfait RobinMalfait enabled auto-merge (squash) February 21, 2025 14:06
@RobinMalfait RobinMalfait merged commit b47b6d2 into main Feb 21, 2025
5 checks passed
@RobinMalfait RobinMalfait deleted the fix/double-translate-z-px branch February 21, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobinMalfait @philipp-spiess