Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haml pre processor #17051

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Add Haml pre processor #17051

merged 2 commits into from
Mar 7, 2025

Conversation

RobinMalfait
Copy link
Member

This PR ensures we extract candidates from Haml files.

Fixes: #17050

@RobinMalfait RobinMalfait requested a review from a team as a code owner March 7, 2025 20:57
@RobinMalfait RobinMalfait merged commit 7005ad7 into main Mar 7, 2025
5 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-17050 branch March 7, 2025 21:32
@topherfangio
Copy link

I just tried this on the insiders track and it is mostly working!

Unfortunately, I'm still having some odd troubles.

For example %h3.mt-24.text-center.text-4xl.font-bold.italic does everything but the .mt-24. I tried removing the %h3 so that it was just a div, but no luck.

I'm going to clone the repo and see if I can add some tests to do some more debugging and see if I can come up with additional tests that would be helpful.

Thanks for your work on this! 🙌

@RobinMalfait
Copy link
Member Author

@topherfangio with just the input you shared it seems to work for me. Can you check 2 things for me:

  1. Is this happening in a .haml file or another file?
  2. The context around this is important, so can you share the full file this is happening in?

If you can come up with a fix that would be nice, if not, a new GitHub issue with a minimal reproduction repo attached would be appreciated. That way we can link to the issue in the new PR and keep it easier to track issues 👍

@topherfangio
Copy link

I cloned the project and am tying to get started with it but running into some issues.

I'll try to put together a repo that reproduces it, but in the meantime, you can see the failing HAML file here: https://github.com/profoundry-us/loco_motion/blob/main/docs/demo/app/views/application/home.html.haml

Thanks for looking into this!

@topherfangio
Copy link

@RobinMalfait Here is the reproduction URL.

https://github.com/profoundry-us/tailwind4-issues-reproduction

I tested a handful of other classes, and the only one I noticed missing was the mt-24. Seems like it got everything else (so far).

@RobinMalfait
Copy link
Member Author

@topherfangio thanks! Fix incoming here:

@topherfangio
Copy link

@RobinMalfait You are awesome!!! Thank you so much! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4.0.12] Most classes in HAML files aren't being detected
3 participants