Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure classes between > and < are properly extracted #17094

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where candidates inside >…< were not always correctly extracted. This happens in XML-like languages where the classes are inside of these boundaries.

E.g.:

<!-- Fluid template language -->
<f:variable name="bgStyle">
  <f:switch expression="{data.layout}">
    <f:case value="0">from-blue-900 to-cyan-200</f:case>
    <!--              ^^^^^^^^^^^^^^^^^^^^^^^^^      -->
    <f:case value="1">from-cyan-600 to-teal-200</f:case>
    <f:defaultCase>from-blue-300 to-cyan-100</f:defaultCase>
  </f:switch>
</f:variable>

Fixes: #17088

Test plan

  1. Added a new test
  2. Existing tests pass

@RobinMalfait RobinMalfait requested a review from a team as a code owner March 9, 2025 19:19
@RobinMalfait RobinMalfait merged commit bc5a8c3 into main Mar 10, 2025
5 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-17088 branch March 10, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classes not generated after upgrading npm packages when CSS classes are inside TYPO3 Fluid template tags
3 participants