Add Input & Output check to CLI #17311
Merged
+83
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an error if the input and output file for the CLI are identical.
…les identical (along with ensuring path resolution)
philipp-spiess
approved these changes
Mar 24, 2025
|
Awesome, thank you so much 🙇 |
RobinMalfait
requested changes
Mar 24, 2025
| @@ -95,6 +95,15 @@ export async function handle(args: Result<ReturnType<typeof options>>) { | |||
| } | |||
| } | |||
|
|
|||
| // Check if the input and output file paths are identical, otherwise return an | |||
| // error to the user. | |||
| if (args['--input'] === args['--output']) { | |||
There was a problem hiding this comment.
Before we merge this I want to check 1 small thing. Commenting here to prevent auto merge from happening.
There was a problem hiding this comment.
So one edge case here is that - can be used by both the --input and --output, e.g.: --input - --output -. The - means "use stdin and stdout respectively". In this case we don't want the error to show up.
Added a failing integration test + a fix for this.
(I also ran prettier in a separate commit)
RobinMalfait
approved these changes
Mar 24, 2025
|
Thanks you! These changes will be available in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an error if the input and output file for the CLI are identical.