Refactor codemod structure #17484
Merged
Refactor codemod structure #17484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript was complaining in this file because `parseImportParams` can return `null` but we didn't take that into account.
TypeScript was complaining that this was missing. While `undefined` would've been falsey as well, this at least fixes the TypeScript warning/error.
This will make it consistent with the CSS and Config migrations. In the next commit, we will hoist the files because right now it looks like `codemod/template/codemods`.
This moves the codemods for the templates up 1 directory. This will make it consistent with the CSS and Config codemods setup. This now means that `./src/codemods/template/codemods/*` becomes `./src/codemods/template/*`.
This is _just_ migrating the prefix string from let's say `tw-` to `tw:`. Not migrating the prefix of each candidate in your template / `@apply` files.
RobinMalfait
force-pushed
the
refactor/codemods-structure
branch
from
c26cbae to
ec92fd4
Compare
thecrypticace
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an internal refactor of the codemods package structure that will make a few follow-up PRs easier.
Essentially what happens is:
./src/template/intosrc/codemods/template/./src/codemodsinto./src/codemods/css(because the CSS related codemods already)./src/codemods/config/.migrate-.migrate…When looking at this PR, go commit by commit, it will be easier. In a lot of cases, it's just moving files around but those commits also come with changes to the code just to update the imports.
[ci-all]