Improve percentage canonicalization #19072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have `10.0%` or `10%` they should be the same thing. So we pass the `10.0` and `10` through `Number` to normalize the value. We only have to do this for values containing a `.`.
We are only interested in percentages containing a `.`. This way we can normalize `10.0%` as `10%` by using `Number(value)` and re-attaching the `%`. With this, a `10.0%` and `10%` would be considered the same. The regex in theory could include a leading `[+-]` but that won't have an effect here, and could be even more confusing when it's being used in a `calc(…)` expression.
thecrypticace
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the canonicalization of percentage values such that
[.1],[.10],[10%]and[10.0%]are all treated as the same value.Right now we're only focusing on percentages. We can likely do this for all numbers, but I'm a little afraid of places where you can have multiple numbers separated by multiple dots (think SVGs).
Test plan