Adds support for tailwind.config.cjs files
#3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3181 +/- ##
==========================================
+ Coverage 93.28% 93.33% +0.05%
==========================================
Files 178 178
Lines 1831 1846 +15
Branches 323 328 +5
==========================================
+ Hits 1708 1723 +15
Misses 105 105
Partials 18 18
Continue to review full report at Codecov.
|
|
This will also likely need a small note added to the docs and support in |
fedeci
reviewed
Dec 23, 2020
natemoo-re
force-pushed
the
support-cjs
branch
from
4d1ed81
to
80b393b
Compare
|
Thanks! |
This was referenced Mar 15, 2021
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
adamwathan
pushed a commit
that referenced
this pull request
May 7, 2021
* feat: automatically init and resolve tailwind.config.cjs files * test: add tests for default tailwind.config.cjs resolution * fix `cjsConfigFile` constant * Fix JSDoc type of isModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default resolution and
npx tailwind initsupport fortailwind.config.cjsfiles.Currently, users who rely on Node ESM with
"type": "module"(officially supported sincenode@12.17.0) must manuallyrequireand pass their Tailwind config file to Tailwind.Implementing true
esm-compliant config files would likely be a large undertaking (requested in #2284), but this PR is a fairly simple stop-gap. With these changes, ESM users will now have the exact same DX as CJS users.Changes
tailwind.config.cjsfile if one existsnpx tailwind initwill automatically generate atailwind.config.cjsfile when run inside of a project with"type": "module"inpackage.jsonnpx tailwind init -pwill generate atailwind.config.cjsfile and apostcss.config.cjsfile when run inside of a project with"type": "module"inpackage.json