Skip to content

Replace stylefmt with perfectionist #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 22, 2018
Merged

Replace stylefmt with perfectionist #358

merged 4 commits into from
Jan 22, 2018

Conversation

damiani
Copy link
Contributor

@damiani damiani commented Jan 19, 2018

Addresses #322

This PR switches the dependency stylefmt with perfectionist. stylefmt was throwing a handful of errors during compilation, and appears to be a bit outdated; in fact, the maintainer of stylefmt cautions: "NOTICE: Consider other tools before adopting stylefmt".

One of those other tools is perfectionist, which has a PostCSS plugin so it can drop in easily as a replacement. There are a few slight differences between the styles enforced by the two tools, so the test fixture tailwind-output.css has been updated accordingly, and all tests pass. All in all, though, the resulting output is very clean.

@adamwathan adamwathan merged commit 6ce550c into tailwindlabs:master Jan 22, 2018
@adamwathan
Copy link
Member

Thanks Keith!

@renovate renovate bot mentioned this pull request Mar 6, 2018
Merged
thecrypticace pushed a commit that referenced this pull request Jul 31, 2025
@depfu
Update jiti 2.4.2 → 2.5.1 (minor) (#18651)
7010a9b 
Here is everything you need to know about this update. Please take a
good look at what changed and the test results before merging this pull
request.

### What changed?




#### ✳️ jiti (2.4.2 → 2.5.1) · [Repo](https://github.com/unjs/jiti) ·
[Changelog](https://github.com/unjs/jiti/blob/main/CHANGELOG.md)



<details>
<summary>Release Notes</summary>
<h4><a
href="https://github.com/unjs/jiti/releases/tag/v2.5.1">2.5.1</a></h4>

<blockquote><p dir="auto"><a
href="https://bounce.depfu.com/github.com/unjs/jiti/compare/v2.5.0...v2.5.1">compare
changes</a></p>
<h3 dir="auto">🩹 Fixes</h3>
<ul dir="auto">
<li>
<strong>interop:</strong> Passthrough module if it is a promise (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/389">#389</a>)</li>
</ul></blockquote>
<h4><a
href="https://github.com/unjs/jiti/releases/tag/v2.5.0">2.5.0</a></h4>

<blockquote><p dir="auto"><a
href="https://bounce.depfu.com/github.com/unjs/jiti/compare/v2.4.2...v2.5.0">compare
changes</a></p>
<h3 dir="auto">🚀 Enhancements</h3>
<ul dir="auto">
<li>Use <code class="notranslate">sha256</code> for cache entries in
FIPS mode (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/375">#375</a>)</li>
<li>Support <code class="notranslate">rebuildFsCache</code> ( <code
class="notranslate">JITI_REBUILD_FS_CACHE</code>) (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/379">#379</a>)</li>
</ul>
<h3 dir="auto">🩹 Fixes</h3>
<ul dir="auto">
<li>Interop modules with null/undefined default export (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/377">#377</a>)</li>
<li>Handle <code class="notranslate">require(&lt;json&gt;)</code> in
register mode (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/374">#374</a>)</li>
</ul>
<h3 dir="auto">📦 Dependencies</h3>
<ul dir="auto">
<li>Updated bundled dependencies (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/compare/v2.4.2...v2.5.0">compare
changes</a>)</li>
</ul>
<h3 dir="auto">📖 Docs</h3>
<ul dir="auto">
<li>Add defaults in JSDocs (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/365">#365</a>)</li>
</ul>
<h3 dir="auto">✅ Tests</h3>
<ul dir="auto">
<li>Only include src for coverage report (<a
href="https://bounce.depfu.com/github.com/unjs/jiti/pull/372">#372</a>)</li>
</ul>
<h3 dir="auto">❤️ Contributors</h3>
<ul dir="auto">
<li>Kricsleo (<a
href="https://bounce.depfu.com/github.com/kricsleo">@kricsleo</a>)
🌟</li>
<li>Pooya Parsa (<a
href="https://bounce.depfu.com/github.com/pi0">@pi0</a>)</li>
<li>Kanon (<a
href="https://bounce.depfu.com/github.com/ysknsid25">@ysknsid25</a>)</li>
<li>Arya Emami (<a
href="https://bounce.depfu.com/github.com/aryaemami59">@aryaemami59</a>)</li>
</ul></blockquote>
<p><em>Does any of this look wrong? <a
href="https://depfu.com/packages/npm/jiti/feedback">Please let us
know.</a></em></p>
</details>

<details>
<summary>Commits</summary>
<p><a
href="https://github.com/unjs/jiti/compare/340e2a733c35df66c85667ef254eab672f5de210...61fa80358bc71708daf104c1205315d8e5867e4b">See
the full diff on Github</a>. The new version differs by 17 commits:</p>
<ul>
<li><a
href="https://github.com/unjs/jiti/commit/61fa80358bc71708daf104c1205315d8e5867e4b"><code>chore(release):
v2.5.1</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/ad268df55b9d5df4d365b3bf5c9607b4e12dd34a"><code>fix(interop):
passthrough module if it is a promise (#389)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/62eac09b1566e05b87039b5954b344c50fe9da36"><code>chore(release):
v2.5.0</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/54461d60611c55074a1f799f99224e24f557eb84"><code>fix(register):
handle `require(&lt;json&gt;)` (#374)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/ea2340d1d092c72daec57c48f0fb98ec93ab2bdd"><code>fix:
interop modules with nil default export (#377)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/2e5a282f4c67a2fd2050d849e7f844d5e4c9bb21"><code>feat:
`rebuildFsCache` ( `JITI_REBUILD_FS_CACHE`) (#379)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/63e907fe3545afe1d376ecce80e5f49f387e1821"><code>feat:
use `sha256` for cache entries in fips mode (#375)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/c567a37af6ccdcd18389ddf1ac121bfdc2aa2149"><code>chore:
update snapshot</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/fb2da1965405e9c52750726761f6b2bfa36ff3ae"><code>test:
only include src for coverage report (#372)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/c9fb9fc0206a2cd7fcc8eaf91328f8d9dd3f3c8f"><code>chore(deps):
update autofix-ci/action digest to 635ffb0 (#385)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/dde7c823fae4213ecfb3e35b70a02c05e166ce81"><code>chore:
lint</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/35a6a618609f967df3e5e05b295efa462f291206"><code>chore:
update deps</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/b396aec45847a32677417ea9dfc78098b6d45c23"><code>chore:
add defaults in JSDocs (#365)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/aa541a64ae86b41fb4a17fdba26a2cebb6395d4d"><code>chore(deps):
update autofix-ci/action digest to 551dded (#358)</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/fb2b903cc2673652a1bccf6c9b7b9c520c9bf165"><code>chore:
update deps</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/c7cfeedbd2326976857bcd62726d73401d25dc03"><code>test:
update snapshot</code></a></li>
<li><a
href="https://github.com/unjs/jiti/commit/6b7fe8b7e6f60f60c26837fadd6288ce2e047b5d"><code>chore:
update ci</code></a></li>
</ul>
</details>












---
![Depfu
Status](https://depfu.com/badges/edd6acd35d74c8d41cbb540c30442adf/stats.svg)

[Depfu](https://depfu.com) will automatically keep this PR
conflict-free, as long as you don't add any commits to this branch
yourself. You can also trigger a rebase manually by commenting with
`@depfu rebase`.

<details><summary>All Depfu comment commands</summary>
<blockquote><dl>
<dt>@​depfu rebase</dt><dd>Rebases against your default branch and
redoes this update</dd>
<dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits
that you've made to it</dd>
<dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and
conflicts are resolved</dd>
<dt>@​depfu cancel merge</dt><dd>Cancels automatic merging of this
PR</dd>
<dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd>
<dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if
it's closed)</dd>
<dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency
and closes this PR</dd>
<dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major
updates for this dependency and closes this PR</dd>
<dt>@​depfu resume</dt><dd>Future versions of this dependency will
create PRs again (leaves this PR as is)</dd>
</dl></blockquote>
</details>

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damiani @adamwathan