Skip to content

Make link styling opt-in instead of opt-out #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

Make link styling opt-in instead of opt-out #760

merged 1 commit into from
Mar 13, 2019

Conversation

adamwathan
Copy link
Member

This is an opinionated and breaking change, but I am personally sick of adding no-underline to 95% of links on the projects I work on. Asking people to add underline when they want an underline seems like the better trade-off to me.

Similarly, I literally never want the default browser blue, so inherit seems like a much more useful default.

@autumnwoodberry
Copy link

I almost always have a .link style that needs to be added to every link anyway so I think this is a good idea.

@adamwathan adamwathan merged commit ce4da4e into next Mar 13, 2019
@adamwathan adamwathan deleted the reset-link-styles branch March 13, 2019 23:35
thecrypticace pushed a commit that referenced this pull request May 19, 2025
@depfu
Update semver 7.7.1 → 7.7.2 (patch) (#18084)
7013ca3 
Here is everything you need to know about this update. Please take a
good look at what changed and the test results before merging this pull
request.

### What changed?




#### ✳️ semver (7.7.1 → 7.7.2) ·
[Repo](https://github.com/npm/node-semver) ·
[Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)



<details>
<summary>Release Notes</summary>
<h4><a
href="https://github.com/npm/node-semver/releases/tag/v7.7.2">7.7.2</a></h4>

<blockquote><h2 dir="auto">
<a
href="https://bounce.depfu.com/github.com/npm/node-semver/compare/v7.7.1...v7.7.2">7.7.2</a>
(2025-05-12)</h2>
<h3 dir="auto">Bug Fixes</h3>
<ul dir="auto">
<li>
<a
href="https://bounce.depfu.com/github.com/npm/node-semver/commit/fcafb61ed566ff8ccf24818dd94b76738f037aa4"><code
class="notranslate">fcafb61</code></a> <a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/780">#780</a>
add missing <code class="notranslate">'use strict'</code> directives (<a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/780">#780</a>)
(<a href="https://bounce.depfu.com/github.com/Fdawgs">@Fdawgs</a>)</li>
<li>
<a
href="https://bounce.depfu.com/github.com/npm/node-semver/commit/c99f336fa3bdff465652f9041eab2127d2f52eb2"><code
class="notranslate">c99f336</code></a> <a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/781">#781</a>
prerelease identifier starting with digits (<a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/781">#781</a>)
(<a
href="https://bounce.depfu.com/github.com/mbtools">@mbtools</a>)</li>
</ul>
<h3 dir="auto">Chores</h3>
<ul dir="auto">
<li>
<a
href="https://bounce.depfu.com/github.com/npm/node-semver/commit/c760403b935d3ad35f83e9bbe5ebe1badef2fc71"><code
class="notranslate">c760403</code></a> <a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/784">#784</a>
template-oss-apply for workflow permissions (<a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/784">#784</a>)
(<a
href="https://bounce.depfu.com/github.com/wraithgar">@wraithgar</a>)</li>
<li>
<a
href="https://bounce.depfu.com/github.com/npm/node-semver/commit/2677f2a88334b0e728dbfe9ad9f5f57458437c87"><code
class="notranslate">2677f2a</code></a> <a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/778">#778</a>
bump @npmcli/template-oss from 4.23.6 to 4.24.3 (<a
href="https://bounce.depfu.com/github.com/npm/node-semver/pull/778">#778</a>)
(<a
href="https://bounce.depfu.com/github.com/dependabot">@dependabot</a>[bot],
<a
href="https://bounce.depfu.com/github.com/npm-cli-bot">@npm-cli-bot</a>)</li>
</ul></blockquote>
<p><em>Does any of this look wrong? <a
href="https://depfu.com/packages/npm/semver/feedback">Please let us
know.</a></em></p>
</details>

<details>
<summary>Commits</summary>
<p><a
href="https://github.com/npm/node-semver/compare/30c438bb46c74f319aa8783f96d233ebf5f4a90d...281055e7716ef0415a8826972471331989ede58c">See
the full diff on Github</a>. The new version differs by 6 commits:</p>
<ul>
<li><a
href="https://github.com/npm/node-semver/commit/281055e7716ef0415a8826972471331989ede58c"><code>chore:
release 7.7.2 (#783)</code></a></li>
<li><a
href="https://github.com/npm/node-semver/commit/fcafb61ed566ff8ccf24818dd94b76738f037aa4"><code>fix:
add missing `&#39;use strict&#39;` directives (#780)</code></a></li>
<li><a
href="https://github.com/npm/node-semver/commit/c760403b935d3ad35f83e9bbe5ebe1badef2fc71"><code>chore:
template-oss-apply for workflow permissions (#784)</code></a></li>
<li><a
href="https://github.com/npm/node-semver/commit/c99f336fa3bdff465652f9041eab2127d2f52eb2"><code>fix:
prerelease identifier starting with digits (#781)</code></a></li>
<li><a
href="https://github.com/npm/node-semver/commit/2677f2a88334b0e728dbfe9ad9f5f57458437c87"><code>chore:
bump @npmcli/template-oss from 4.23.6 to 4.24.3 (#778)</code></a></li>
<li><a
href="https://github.com/npm/node-semver/commit/0b98655dbc1a9eb79370ed80f557be98d1c06587"><code>chore:
bump @npmcli/template-oss from 4.23.4 to 4.23.6 (#760)</code></a></li>
</ul>
</details>












---
![Depfu
Status](https://depfu.com/badges/edd6acd35d74c8d41cbb540c30442adf/stats.svg)

[Depfu](https://depfu.com) will automatically keep this PR
conflict-free, as long as you don't add any commits to this branch
yourself. You can also trigger a rebase manually by commenting with
`@depfu rebase`.

<details><summary>All Depfu comment commands</summary>
<blockquote><dl>
<dt>@​depfu rebase</dt><dd>Rebases against your default branch and
redoes this update</dd>
<dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits
that you've made to it</dd>
<dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and
conflicts are resolved</dd>
<dt>@​depfu cancel merge</dt><dd>Cancels automatic merging of this
PR</dd>
<dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd>
<dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if
it's closed)</dd>
<dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency
and closes this PR</dd>
<dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major
updates for this dependency and closes this PR</dd>
<dt>@​depfu resume</dt><dd>Future versions of this dependency will
create PRs again (leaves this PR as is)</dd>
</dl></blockquote>
</details>

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamwathan @autumnwoodberry