Make theme a function instead of an object when passed to config closures
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
added a commit
to CvX/tailwindcss
that referenced
this pull request
Mar 17, 2019
In a way this combines PRs tailwindlabs#655 and tailwindlabs#774.
CvX
added a commit
to CvX/tailwindcss
that referenced
this pull request
Mar 17, 2019
In a way this combines PRs tailwindlabs#655 and tailwindlabs#774.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were passing the current theme object to lazily evaluated config closures, but this can lead to an unfortunate amount of boilerplate if you need to check for the presence of a given key before referencing it.
This PR makes theme a function instead, where you specify the path to look up as the first argument (using dot notation), and specify a default value if that path doesn't exist as a second argument, just like the
themefunction available in your CSS .Resolves #770.