Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs in Primary Features section of the Pocket template #1323

Closed
iamchubko opened this issue Sep 15, 2022 · 2 comments · Fixed by tailwindlabs/headlessui#1856
Closed

Tabs in Primary Features section of the Pocket template #1323

iamchubko opened this issue Sep 15, 2022 · 2 comments · Fixed by tailwindlabs/headlessui#1856

Comments

@iamchubko
Copy link

iamchubko commented Sep 15, 2022

Describe the bug
In Pocket template, Primary Features block in downloaded repo behave differently compared to https://pocket.tailwindui.com/.

If you select anything but the first tab, it will render span as if only one Tab.Panel was present and was not selected. But in the live version AnimatePresence animates enter and exit as expected and at the end of the transition the only div is always the one we selected, despite being the only one.

To Reproduce
Steps to reproduce the behavior:

  1. Download the latest zip archive with the repo
  2. Start the dev server
  3. Change tabs in Primary Features section

Expected behavior
Downloaded repo should behave exactly like on the website

Screencasts

correct_behaviour.mp4
wrong_behaviour.mp4

Browser/Device (if applicable)

  • OS: Linux Mint 20.3
  • Browser: Brave
  • Version: 1.43.93 (chromium 105)
@thecrypticace
Copy link

Hey this is a regression from a bug fix we did in Headless UI v1.7.1 — @RobinMalfait and I took a look and have come up with a fix which has just been tagged: https://github.com/tailwindlabs/headlessui/releases/tag/%40headlessui%2Freact%40v1.7.2

You can run an npm upgrade to fix this problem. Thanks for reporting it!

The reason prod was working was because it hadn't been updated to v1.7.1 of Headless UI yet.

@iamchubko
Copy link
Author

Can confirm, it is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants