Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we handle the static prop in Tab.Panel components correctly #1856

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Sep 15, 2022

This PR fixes an issue where static Tab Panels didn't take the static prop into account when
rendering the "hidden" panel (to guarantee tab order and matching tab panels).

Fixes: tailwindlabs/tailwindui-issues#1323

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 4:24PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 4:24PM (UTC)

@RobinMalfait RobinMalfait changed the title Ensure we handle static Tab.Panel correctly Ensure we handle the static prop in Tab.Panel components correctly Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs in Primary Features section of the Pocket template
1 participant