Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple characters when rendering NAs #55

Closed
vsimko opened this issue Mar 28, 2016 · 2 comments
Closed

Support for multiple characters when rendering NAs #55

vsimko opened this issue Mar 28, 2016 · 2 comments
Assignees

Comments

@vsimko
Copy link
Collaborator

vsimko commented Mar 28, 2016

There is a parameter na.label. However, it currently only allows for a single character (default "?").
It might be useful to support more characters with some reasonable upper limit.
Example:

corrplot(M2, na.label = "NA", number.cex = .7) # works from v0.76

image

@taiyun Before I implement this, let's discuss the following:

  • Should the limit be 2 chars or more? (I'm voting for 2)
  • Should the default value be "?" or "NA" ? (I'm voting for "?")
@smcinerney
Copy link

Well if na.label was 3 chars or more, would it be scaled or not?
Basically if you can handle 3 chars without much grief, then please do,
otherwise don't. 2 chars like 'NA' is already a huge improvement.
Beware also that you are here using 'NA' on the diagonal axis to signify
"self-correlation is not relevant, since it's always by definition 1",
not to signify "this series contains NAs, hence correlation can't be computed except
with use="complete".
But personally I would set/override a default na.label = "", not
either "?" or "NA". But I don't think it matters too much what the default is
because we can override it.

Stephen

@taiyun
Copy link
Owner

taiyun commented Mar 29, 2016

Should the limit be 2 chars or more? (I'm voting for 2)
Should the default value be "?" or "NA" ? (I'm voting for "?")

Agree.

vsimko added a commit to vsimko/corrplot that referenced this issue Mar 29, 2016
vsimko added a commit to vsimko/corrplot that referenced this issue Mar 29, 2016
vsimko added a commit that referenced this issue Mar 29, 2016
@vsimko vsimko closed this as completed Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants