Handle effectively the Android NDK equivalent of Debian's multiarch in library searching #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n library searching Don't know how to specify default path suffixes, so this won't help with directories added to CMAKE_PREFIX_PATH later, but it's useful. (Specifically, needed for CrystaX boost libs to be found, but useful in general.)
|
I'm agree with the idea of this change but not quite sure that modifying |
|
@taka-no-me What are the reasons against this? |
|
My impression from reading cmake docs is that is the place to put the path, since things that happen in the tool chain file are effectively "system", and thus the non system variables should be left under control of the build and user. Extending this particular variable allows find library to work without explicit additions per platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how to specify default path suffixes, so this won't help with
directories added to CMAKE_PREFIX_PATH later, but it's useful.
(Specifically, needed for CrystaX boost libs to be found, but useful in general, especially if the user has other libs installed to the CMAKE_INSTALL_PREFIX.)