Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to standard lint rule #9

Closed
uneco opened this issue Jan 16, 2019 · 2 comments
Closed

Conform to standard lint rule #9

uneco opened this issue Jan 16, 2019 · 2 comments

Comments

@uneco
Copy link
Contributor

uneco commented Jan 16, 2019

this project using snake cases and inconsistent use of semicolon in TypeScript sources.
I propose using stronger and more standard syntax.
@uneco
Copy link
Contributor Author

uneco commented Jan 16, 2019 •
edited
Loading

how about this?

{
  "extends": "tslint:recommended",
  "rules": {
    "ordered-imports": false,
    "member-ordering": false,
    "object-literal-sort-keys": false,
    "interface-name": false,
    "semicolon": [true, "never"],
    "quotemark": [true, "single"]
  }
}

@takanakahiko
Copy link
Owner

@uneco Sounds good! PRs welcome.

uneco added a commit to uneco/slack-emoji-meister that referenced this issue Jan 16, 2019
@uneco
fix: takanakahiko#9 Conform to standard lint rule
f38592e
uneco added a commit to uneco/slack-emoji-meister that referenced this issue Jan 16, 2019
@uneco
fix: takanakahiko#9 Conform to standard lint rule
d307af9
uneco added a commit to uneco/slack-emoji-meister that referenced this issue Jan 16, 2019
@uneco
fix: takanakahiko#9 Conform to standard lint rule
1025af7
uneco added a commit to uneco/slack-emoji-meister that referenced this issue Jan 16, 2019
@uneco
fix: takanakahiko#9 Conform to standard lint rule
0485366
uneco added a commit to uneco/slack-emoji-meister that referenced this issue Jan 16, 2019
@uneco
fix: takanakahiko#9 Conform to standard lint rule
a9fa955
@uneco uneco mentioned this issue Jan 16, 2019
Merged
2 tasks
takanakahiko pushed a commit that referenced this issue Jan 16, 2019
@uneco @takanakahiko
fix: #9 Conform to standard lint rule (#11)
c9092fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uneco @takanakahiko