Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build environment #18

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Improve build environment #18

merged 5 commits into from
Jan 16, 2019

Conversation

potato4d
Copy link
Contributor

Changes

  • Always strict mode on TypeScript code
  • Use babel.config.js intead of .babelrc
  • Use 2 spaces indent(According to EditorConfig)
  • Use babel target node-current
  • Use tsc dry-run on lint

CheckList

  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

takanakahiko
takanakahiko approved these changes Jan 16, 2019
View reviewed changes
Copy link
Owner

@takanakahiko takanakahiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your PR.

@takanakahiko takanakahiko merged commit e682a43 into takanakahiko:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanakahiko takanakahiko takanakahiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@potato4d @takanakahiko