-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/2024 12 make encoder and decoder compatible with twiddles #348
Merged
takapi327
merged 28 commits into
master
from
enhancement/2024-12-Make-Encoder-and-Decoder-compatible-with-Twiddles
Dec 31, 2024
Merged
Enhancement/2024 12 make encoder and decoder compatible with twiddles #348
takapi327
merged 28 commits into
master
from
enhancement/2024-12-Make-Encoder-and-Decoder-compatible-with-Twiddles
Dec 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takapi327
added
💪 enhancement
Functional enhancement
🔧 refactor
Refactoring
project:queryBuilder
Addition and modification of functionality to Query Builder projects
project:dsl
Addition and modification of functionality to DSL projects
project:schema
Addition and modification of functionality to Schema projects
project:statement
Addition and modification of functionality to Statement projects
labels
Dec 30, 2024
takapi327
deleted the
enhancement/2024-12-Make-Encoder-and-Decoder-compatible-with-Twiddles
branch
December 31, 2024 08:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
Functional enhancement
project:dsl
Addition and modification of functionality to DSL projects
project:queryBuilder
Addition and modification of functionality to Query Builder projects
project:schema
Addition and modification of functionality to Schema projects
project:statement
Addition and modification of functionality to Statement projects
🔧 refactor
Refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Details
Modification of Encoder and Decoder into a composable form using twiddles.
The method of building custom-type Decoders has changed. With this modification, Decoder can be converted to any type using the map function.
Decoder is still constructed implicitly.
However, implicit searches may fail if there are many properties in the model.
In such cases, raising the search limit in the compilation options may resolve the problem.
However, it may lead to amplification of compilation time. In that case, it can also be resolved by manually building the Decoder as follows.
This is true not only for Decoder but also for Encoder.
Pull Request Checklist
References