-
Notifications
You must be signed in to change notification settings - Fork 234
Update to Maven 3.8.1 #177
base: master
Are you sure you want to change the base?
Conversation
Hi @clemstoquart, in the mean time you can update the wrapper by explicitly specifying the Maven version
|
I get this error when trying to run that command:
|
@EuniceB I hope you've already found what was wrong. I just succeeded as follows.
|
@@ -1,3 +1,3 @@ | |||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip | |||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.1/apache-maven-3.8.1-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be 3.8.2 now
Would it perhaps be a sensible default to generate the version at whatever version of Maven the user is running this plugin with? Like, if I am generating the wrapper from Maven 3.10.14 some time in the far future, it probably makes sense to say that I would like it to default to Maven 3.10.14, since that is what I am developing with. |
Seems perfectly reasonable. |
when can we merge this? Since maven is pushing the release date every time further to the feature. Also I have one wish to this wrapper. it would be nice if the wrappers binary and code would be placed in the .m2 or similar folder as every code and security checker has issues with the wrapper. So that a mini script just points to the folder outside of the repo. |
@ascopes and @YunaBraska please make separate issues for your asks above. Maven 3.8.2 has been released so I’ll update this to 3.8.2 and release as soon as i can. |
@jvanzyl I can only create a pull request but no issue :( |
Should be fixed now. I'll try to get a release out and make sure anything here is merge over at the wrapper at Apache, which hopefully will be released soon. |
Hi,
I know the wrapper will be integrated to maven shortly but in the meantime let's keep it up to date.