Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

Update to Maven 3.8.1 #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clemstoquart
Copy link

Hi,

I know the wrapper will be integrated to maven shortly but in the meantime let's keep it up to date.

@helpermethod
Copy link

helpermethod commented Apr 8, 2021

Hi @clemstoquart,

in the mean time you can update the wrapper by explicitly specifying the Maven version

mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.8.2

@EuniceB
Copy link

EuniceB commented Jun 7, 2021

Hi @clemstoquart,

in the mean time you can update the wrapper by explicitly specifying the Maven version

mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.8.1

I get this error when trying to run that command:

[ERROR] Unknown lifecycle phase ".8.1". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/LifecyclePhaseNotFoundException

@onacit
Copy link

onacit commented Aug 10, 2021

@EuniceB I hope you've already found what was wrong. I just succeeded as follows.

% mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.8.1
[INFO] Scanning for projects...
[INFO]
[INFO] --------------< ...:... >---------------
[INFO] Building ... 0.1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven:0.7.7:wrapper (default-cli) @ ... ---
[INFO]
[INFO] Maven Wrapper version 0.5.6 has been successfully set up for your project.
[INFO] Using Apache Maven: 3.8.1
[INFO] Repo URL in properties file: https://repo.maven.apache.org/maven2
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.616 s
[INFO] Finished at: 2021-08-10T17:22:48+09:00
[INFO] ------------------------------------------------------------------------

@@ -1,3 +1,3 @@
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.1/apache-maven-3.8.1-bin.zip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be 3.8.2 now

@ascopes
Copy link

ascopes commented Oct 22, 2021

Would it perhaps be a sensible default to generate the version at whatever version of Maven the user is running this plugin with?

Like, if I am generating the wrapper from Maven 3.10.14 some time in the far future, it probably makes sense to say that I would like it to default to Maven 3.10.14, since that is what I am developing with.

@jvanzyl
Copy link

jvanzyl commented Oct 22, 2021

Seems perfectly reasonable.

@YunaBraska
Copy link

YunaBraska commented Nov 19, 2021

when can we merge this? Since maven is pushing the release date every time further to the feature.

Also I have one wish to this wrapper. it would be nice if the wrappers binary and code would be placed in the .m2 or similar folder as every code and security checker has issues with the wrapper. So that a mini script just points to the folder outside of the repo.

@jvanzyl
Copy link

jvanzyl commented Nov 21, 2021

@ascopes and @YunaBraska please make separate issues for your asks above. Maven 3.8.2 has been released so I’ll update this to 3.8.2 and release as soon as i can.

@YunaBraska
Copy link

@jvanzyl I can only create a pull request but no issue :(

@jvanzyl
Copy link

jvanzyl commented Nov 21, 2021

@jvanzyl I can only create a pull request but no issue :(

Should be fixed now. I'll try to get a release out and make sure anything here is merge over at the wrapper at Apache, which hopefully will be released soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants