Optimize the log output of the smart builder #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cstamas can you review? |
laeubi
force-pushed
the
optimized_log_output
branch
from
bf92a1c to
14a5c95
Compare
gnodet
reviewed
Mar 8, 2023
| "Task segments : " + taskSegments.stream().map(Object::toString).collect(Collectors.joining(" "))); | ||
| logger.info("Build maximum degree of concurrency is " + degreeOfConcurrency); | ||
| logger.info("Total number of projects is " + session.getProjects().size()); | ||
| logger.debug("Task segments : " + Joiner.on(" ").join(taskSegments)); |
There was a problem hiding this comment.
And maybe even a lambda if possible logger.debug("Task segments: {}", () -> Joiner.on(" ").join(taskSegments));
There was a problem hiding this comment.
Done (as far as slf4j level allows) lamda semm not supported, but I wrapped is in a debugenabled block now.
laeubi
force-pushed
the
optimized_log_output
branch
from
14a5c95 to
230bfac
Compare
Currently the smartbuilder prints some messages that are more debug infos at the info level that are hard to understand for the user. This change do the following: - print start/stop messages at the debug level - in the summary print only the average project wall time - print the total concurrency as percentage - if the effective concurrency is lower than 80% print a list of bottlenecks and a hint to the user how to get further details
laeubi
force-pushed
the
optimized_log_output
branch
from
230bfac to
09fe855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the smartbuilder prints some messages that are more debug infos at the info level that are hard to understand for the user.
This change do the following:
An example output then might look like this: