Changed Contains query to ensure bool convertion #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n false in case of cast fail
andrebires
reviewed
Oct 7, 2019
src/Take.Elephant.Sql/StorageBase.cs
Outdated
| @@ -47,7 +47,8 @@ protected async Task<bool> ContainsAsync(IDictionary<string, object> filterValue | |||
| { | |||
| using (var command = connection.CreateContainsCommand(DatabaseDriver, Table.Schema, Table.Name, filterValues)) | |||
| { | |||
| return (bool)await command.ExecuteScalarAsync(cancellationToken).ConfigureAwait(false); | |||
| var queryResult = await command.ExecuteScalarAsync(cancellationToken).ConfigureAwait(false); | |||
| return queryResult is bool result && result; | |||
There was a problem hiding this comment.
It is better to throw an exception instead of silently accepting if the query returns a value different than boolean._
There was a problem hiding this comment.
Maybe is better to remove this modification and leave just the changed SQL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed contains SQL query to ensure BIT casting and C# code to return always a bool