Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI tags in 3.8+ dropped the 'm' #203

Closed
dmulkey-qubitekk opened this issue Jul 30, 2020 · 1 comment
Closed

ABI tags in 3.8+ dropped the 'm' #203

dmulkey-qubitekk opened this issue Jul 30, 2020 · 1 comment

Comments

@dmulkey-qubitekk
Copy link

Hi there,

On line 40 of wheels.py (definition of score_abi under CompatibilityScorer), there's a comment of "Is the m reliable" referring to the 'm' in ABI tags of 'cp36m' or 'cp37m.' In packages with Python 3.8+, the m has been dropped. Examples include matplotlib, scipy, numpy, and Pillow.

The release notes for wheel confirm this. Here's the referenced PR. Looks like it stems from changes described under What's New In Python 3.8.

A (lame?) workaround is to redefine d as follows (haven't checked for passing tests):

d = {'cp%sm' % py_version_nodot: 3,  # Is the m reliable?  
    'cp%s' % py_version_nodot: 3,  
    'abi3': 2, 'none': 1}

Cheers,
-Daniel

@dmulkey-qubitekk
Copy link
Author

Shoot, I checked for preexisting issues, but I didn't notice that someone already submitted a PR addressing this. Sorry! Thanks for making a great package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant